Verify that blocks implements EditableBlockService to add/edit them. #1624
Conversation
jordisala1991
force-pushed
the
hotfix/allow-only-to-insert-editable-blocks
branch
5 times, most recently
from
f284009 to
aa77aeb
Compare
jordisala1991
changed the title
|
Needs #1623 first. |
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
hotfix/allow-only-to-insert-editable-blocks
branch
from
aa77aeb to
e662e16
Compare
| foreach ($blockServices as $code => $blockService) { | ||
| if ($blockService instanceof EditableBlockService) { | ||
| continue; | ||
| } | ||
|
|
||
| unset($blockServices[$code]); | ||
| } |
There was a problem hiding this comment.
We're doing this logic at least twice.
Would it make sens to add/modify a method in BlockServiceManager then ?
If most of the time/always we need to work on EditableBlockService only in PageBundle, it might make sens.
WDYT ?
There was a problem hiding this comment.
BlockServiceManager is from block-bundle, how could we handle this change?
There was a problem hiding this comment.
I was wondering if we should introduce an EditableBlockServiceManager in BlockBundle then.
Or introduce getEditableService and getEditableServiceByContext...
But this solution is currently the only one we have
|
Should we merge this or wait for another solution? @VincentLanglet ? |
I'm ok merging this:
The only question would be, would it be useful to provide something in the BlockBundle to avoid this extra code ; if yes we might create a feature request. |
|
Check this comment about my thoughts about the implementation: #1621 (comment) |
Subject
I am targeting this branch, because this becomes a problem on 4.x since block bundle splitted interfaces.
Closes #1621
Changelog