Fix shared block service #1618
Fix shared block service #1618
Conversation
|
This issue is hard to test because it involves the need of a panther test. |
jordisala1991
force-pushed
the
hotfix/fix-shared-blocks
branch
from
c8bab66 to
b7a97a1
Compare
|
@eerison on my tests, with these changes, the shared block works fine, can you try this? |
| @@ -130,20 +139,17 @@ public function load(BlockInterface $block): void | |||
| */ | |||
| private function getBlockBuilder(AdminFormMapper $form): FormBuilderInterface | |||
| { | |||
| $admin = $form->getAdmin(); | |||
There was a problem hiding this comment.
it doesn't work with the admin coming from the form ?
There was a problem hiding this comment.
When you use the admin from the form, you are using BlockAdmin, but this field is to related with SharedBlockAdmin. What is more interesting is that this is happening inside PageAdmin, so for some reason, not only the admin linked is not the correct one which shows Blocks, not shared blocks. BUT also Sonata is smart enough to know Block is child of Page and automatically builds child urls, showing only blocks related to that page. And the final funnier thing is that for child urls , the select button does not work, I can't understand why tho.
So to answer you:
- No, the admin is not BlockAdmin but SharedBlockAdmin
- Previously only blocks belonging to the page were shown (instead of the expected behavior which is showing ALL shared blocks)
- Sonata has a bug somewhere (I didn't fully understand why) that make the previous implementation fail because it tries to open a modal with a child, but without providing the correct linkParameters (it is hard to explain because I do not fully know what is happening there)
- But the bug pointed on 3. is not really related to this issue, which is: We were relating to block instead of shared block.
Maybe we want to investigate more about this 3. in the future.
There was a problem hiding this comment.
Or explaining the other way around: If the point 3 didn't exists, this block should work, but it will let you only blocks that are already present on the page, not shared block intended to be reused across pages.
|
Hey @jordisala1991 I tested your branch and I got the same behaviour, I create the block this way 👇🏼 Screen.Recording.2022-09-27.at.09.41.09.mov |
|
I think you are testing another thing, this fixes the shared block service (adding a shared block inside a page), not the batch delete. |
|
ahhh ok! I got it :) let me check again |
|
Hey @jordisala1991 now I can add a share block in my page ❤️ |
Subject
I am targeting this branch, because shared blocks are broken on 4.x.
Fixes: #1495 (comment)