Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend css file for pages #1583

Merged
merged 7 commits into from
Sep 6, 2022

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Aug 31, 2022

Fixing the site's page to work as 3.x

I am targeting this branch, because the bootstrap wasn't loading in site's page.

Closes #1573.

Changelog

### Added
- Added `assets/css/frontend.scss` to use in site's page

To do

  • Fix pipelines
  • Update the documentation;

@eerison
Copy link
Contributor Author

eerison commented Aug 31, 2022

Hey @jordisala1991 to make this accessible from my project, I guess I should run some build here, don't you?

@eerison
Copy link
Contributor Author

eerison commented Aug 31, 2022

I remember some similar issue related with admin bundle

@eerison eerison changed the title Bootstrap 4.x Bootstrap in 4.x Aug 31, 2022
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch 2 times, most recently from a260610 to 84db394 Compare September 2, 2022 06:59
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch from 84db394 to d0262c4 Compare September 2, 2022 07:02
@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

Screenshot 2022-09-02 at 09 13 18

any idea why it's not loading ?

@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

Ok I found the issue

it need to be added here

sonata_page:
    assets:
        stylesheets:
            - bundles/sonatapage/frontend.css

@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

Screenshot 2022-09-02 at 09 29 36

Now it's look nice again :)

@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch from ab6eb57 to e63ff3f Compare September 2, 2022 07:41
@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

Screenshot 2022-09-02 at 10 01 16

@eerison eerison marked this pull request as ready for review September 2, 2022 08:05
@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

Can you review @jordisala1991 and @VincentLanglet

@eerison eerison mentioned this pull request Sep 2, 2022
36 tasks
@eerison eerison changed the title Bootstrap in 4.x Adding bootstrap in site's page Sep 2, 2022
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch from 1565d11 to 539640a Compare September 2, 2022 09:04
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch 2 times, most recently from 61d22d0 to 4658460 Compare September 2, 2022 09:15
@eerison eerison marked this pull request as draft September 2, 2022 09:22
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch from 4658460 to 427a08e Compare September 2, 2022 09:23
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch from 427a08e to 2548916 Compare September 2, 2022 09:29
@eerison eerison marked this pull request as ready for review September 2, 2022 10:31
@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

it worked with default configuration

@eerison eerison marked this pull request as draft September 2, 2022 13:35
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch 3 times, most recently from 6ff846f to f4058bc Compare September 2, 2022 13:55
@eerison
Copy link
Contributor Author

eerison commented Sep 2, 2022

Screenshot 2022-09-02 at 15 53 37

Ok now it's loading only frontend.css :)

@eerison eerison marked this pull request as ready for review September 2, 2022 13:57
@eerison eerison changed the title Adding bootstrap in site's page Add frontend css file for pages Sep 2, 2022
@eerison eerison marked this pull request as draft September 5, 2022 09:07
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch 2 times, most recently from 3bfda51 to 9f178d7 Compare September 5, 2022 10:16
@eerison eerison force-pushed the bug/1573/bootstrap_4.x branch from 9f178d7 to f0aaf9c Compare September 5, 2022 10:16
@eerison eerison marked this pull request as ready for review September 5, 2022 10:18
@eerison
Copy link
Contributor Author

eerison commented Sep 5, 2022

could you check again @jordisala1991

Copy link
Member

@jordisala1991 jordisala1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also deprecate the css and js config on 3.x and remove it on 4.x after (other Prs)

@VincentLanglet
Copy link
Member

We should also deprecate the css and js config on 3.x and remove it on 4.x after (other Prs)

Can you add it to the todo @eerison ?

@jordisala1991 jordisala1991 merged commit ccad471 into sonata-project:4.x Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants