Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notes in Upgrade file #1581

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Adding notes in Upgrade file #1581

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71df80
Adding notes in Upgrade file
eerison Aug 30, 2022
9f6a5e4
Adding slugify service section
eerison Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Please be aware the config
```
sonata_block:
context_manager: sonata.page.block.context_manager

sonata_page:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo it should have its own section inside the upgrade file, this sections talks about SonataBlockBundle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check again @jordisala1991

slugify_service: sonata.page.slugify.cocur
```
won't work anymore then. You should rely on the default value instead.

Expand Down