Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of 'admin_pool' in twig templates #1533

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Remove usage of 'admin_pool' in twig templates #1533

merged 2 commits into from
Aug 10, 2022

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Aug 10, 2022 •
edited
Loading

Subject

I am targeting this branch, because this fixes an issue on 4.x branch.

2 Commits:

  • Add functional tests to show the issue
[critical] Uncaught PHP Exception Twig\Error\RuntimeError: "Variable "admin_pool" does not exist." at /home/runner/work/SonataPageBundle/SonataPageBundle/src/Resources/views/PageAdmin/compose.html.twig line 47
  • Fix tests.

@jordisala1991 jordisala1991 mentioned this pull request Aug 10, 2022
Closed
36 tasks
@VincentLanglet VincentLanglet merged commit 21d2e7d into sonata-project:4.x Aug 10, 2022
@eerison
Copy link
Contributor

eerison commented Aug 10, 2022

Thanks @jordisala1991 it works ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordisala1991 @eerison @VincentLanglet