Create test for templateManager

[eerison]

Cover templateManager

I am targeting this branch, because in 4.x the page content is not rendered, and I need to understand first how it was working, something was changed or removed in 4.x that I can't identify.

Issue #1497

[eerison]

I'm trying to mock the sonata.templating service, but I looks like removed

root@4d1918ef933d:/app# bin/console debug:container sonata.templating

Information for Service "sonata.templating"
===========================================

 ---------------- ------------------------------------------ 
  Option           Value                                     
 ---------------- ------------------------------------------ 
  Service ID       sonata.templating                         
  Class            Sonata\BlockBundle\Templating\TwigEngine  
  Tags             -                                         
  Public           no                                        
  Synthetic        no                                        
  Lazy             no                                        
  Shared           yes                                       
  Abstract         no                                        
  Autowired        no                                        
  Autoconfigured   no                                        
 ---------------- ------------------------------------------ 


 ! [NOTE] The "sonata.templating" service or alias has been removed or inlined when the container was compiled. 

do you have any idea why @VincentLanglet or @Daric971

Edit 1: and It leads to other question, is this make lint-symfony-container working? because I tried to run this locally passing a service that doesn't exist and it doesn't broken

[VincentLanglet]

I know nothing about this service :/

[eerison]

Finally I could cover breadcrumb behaviour in test, I hope it helps me to fix in 4.x.

[eerison]

Could you check this PR @VincentLanglet @jordisala1991 , please :)

[VincentLanglet]

I don't think we put id often ; so I dont like adding some for test, and would prefer something else than

static::assertCount(1, $crawler->filter('#header'));

Not sure what's sonata_page_render_container is doing but you might find somehting to search

[eerison]

But in this case I'm testing the page, and I'm checking if there is an element into the page!
I guess it is fine to test elements into the page using "id", don't you?

[VincentLanglet]

breadcrumb, header, content, ... are way too generic words. What if someone use js on it ? What if he's already is using those ?

Adding id, it just a risk of BC-break with no benefit for the code. It's not like we're using js on something.
You're adding them because you're writting tests. And you should never have your test pushing you to modify your src code.

You can work on the already existing classes. Adding page-breadcrumb class and so on might be a feature to allow overriding the design for user ; it seems better than ids.

But I don't understand the purpose of your test, checking for div in the page ; Checking for url, 200, etc might be enough.

@jordisala1991 wrote a lot of tests on 4.x branch and never needed to add id, or to find some div.

[eerison]

What I want to make sure is if the breadcrumbs are rendered into the page!

[eerison]

page-breadcrumb

Ok I'll try to use page-breadcrumb

[eerison]

Hey @VincentLanglet could you check again please!

I just let the testing checking breadcrumb only, and I'm following the same way from page-header

[eerison]

Hey @jordisala1991 could you review this PR please. and if it's possible merge into 4.x, tomorrow I would try to investigate the problem related with #1497

[jordisala1991]

IMO this test would be much more easy on 4.x with the tests i have already added for render pages.

[VincentLanglet]

Can you open a PR of the merge of 3.x into 4.x @eerison ? There is a lot of issue with this test when I try to merge

[eerison]

Yeah, tomorrow I can do this :)