-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Symfony 5 and 6 #1491
Add Support for Symfony 5 and 6 #1491
Conversation
Depends on how hard is fixing the: LogoutHandlerInterface, we might do first 5.4 and then 6.0 or in the same PR.
|
* @param int $pageId Page identifier | ||
* @param int $blockId Block identifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int|string I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im trying to focus only on needed changes for sf 5/6. This will go to a PHPStan up PR.
c820b95
to
8f220c6
Compare
1e4f448
to
651aa67
Compare
6ac51ec
to
e083038
Compare
There is some work to do still. |
Here the Pr for dev kit: sonata-project/dev-kit#2121 |
Subject
I am targeting this branch, because this is BC break.
Closes #1410
Changelog