Fix phpstan

sonata-project · Aug 22, 2022 · 4631a51 · 4631a51
1 parent 695d2cb
commit 4631a51
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/src/Admin/SharedBlockAdmin.php b/src/Admin/SharedBlockAdmin.php
@@ -14,11 +14,12 @@
 namespace Sonata\PageBundle\Admin;
 
 use Sonata\AdminBundle\Datagrid\ListMapper;
-use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
 use Sonata\AdminBundle\Form\FormMapper;
+use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
 use Sonata\BlockBundle\Block\Service\EditableBlockService;
 use Sonata\BlockBundle\Model\BlockInterface;
 use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery;
+use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQueryInterface as DatagridProxyInterface;
 use Sonata\PageBundle\Model\PageBlockInterface;
 
 /**
@@ -38,9 +39,12 @@ protected function generateBaseRouteName(bool $isChildAdmin = false): string
         return sprintf('%s_%s', parent::generateBaseRouteName($isChildAdmin), 'shared');
     }
 
+    /**
+     * @return DatagridProxyInterface
+     */
     protected function configureQuery(ProxyQueryInterface $query): ProxyQueryInterface
     {
-        \assert($query instanceof ProxyQuery);
+        \assert($query instanceof DatagridProxyInterface);
 
         // Filter on blocks without page and parents
         $rootAlias = current($query->getRootAliases());

diff --git a/src/Controller/PageAdminController.php b/src/Controller/PageAdminController.php
@@ -54,6 +54,8 @@ public static function getSubscribedServices(): array
     }
 
     /**
+     * @param ProxyQueryInterface<object> $query
+     *
      * @throws AccessDeniedException
      */
     public function batchActionSnapshot(ProxyQueryInterface $query): RedirectResponse

diff --git a/src/Controller/SnapshotAdminController.php b/src/Controller/SnapshotAdminController.php
@@ -35,6 +35,8 @@ public static function getSubscribedServices(): array
     }
 
     /**
+     * @param ProxyQueryInterface<object> $query
+     *
      * @throws AccessDeniedException
      */
     public function batchActionToggleEnabled(ProxyQueryInterface $query): RedirectResponse

diff --git a/tests/Page/TemplateManagerTest.php b/tests/Page/TemplateManagerTest.php
@@ -169,6 +169,7 @@ public function testTemplateShowingBreadcrumbIntoThePage(): void
         $container->set('sonata.page.cms.snapshot', $cmsSnapshotManagerMock);
 
         $twig = $container->get('twig');
+        \assert($twig instanceof Environment);
 
         $manager = new TemplateManager($twig, []);
         $response = $manager->renderResponse('test');
-Original file line number
+Diff line change
@@ Expand Up / @@ -54,6 +54,8 @@ public static function getSubscribedServices(): array @@
         }
         /**
+         * @param ProxyQueryInterface<object> $query
+         *
          * @throws AccessDeniedException
          */
         public function batchActionSnapshot(ProxyQueryInterface $query): RedirectResponse
@@ Expand Down @@