Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

remove deprecated corebundle #424

Closed
wants to merge 1 commit into from

Conversation

garak
Copy link

@garak garak commented Feb 21, 2020

Subject

Remove deprecated SonataCoreBundle

I am targeting 3.x, because there's no BC break.

Closes #423

Changelog

### Fixed
- Fix SonataCoreBundle deprecations

@core23
Copy link
Member

core23 commented Feb 21, 2020

Can you verify, that there is no usage for this bundle?

@garak
Copy link
Author

garak commented Feb 21, 2020

Can you verify, that there is no usage for this bundle?

I did a search for related namespaces and ran tests.

@core23
Copy link
Member

core23 commented Feb 21, 2020

Keep in mind, that we use multiple namespaces:
https://github.com/sonata-project/SonataCoreBundle/blob/3.x/composer.json#L70-L73

@core23
Copy link
Member

core23 commented Feb 21, 2020

Just tried the online search...

use Sonata\CoreBundle\Form\FormHelper;

@garak
Copy link
Author

garak commented Feb 21, 2020

You're right, I forgot to search for CoreBundle.
But now I'm not sure how to replace following classes:

  • Sonata\CoreBundle\Form\FormHelper (can't find it in form-extensions)
  • Sonata\CoreBundle\Exception\InvalidParameterException (not sure where to search it)

@core23
Copy link
Member

core23 commented Feb 21, 2020

Unfortunately we can't do this on the stable branch for now

@garak
Copy link
Author

garak commented Feb 21, 2020

What is blocking?

@core23
Copy link
Member

core23 commented Feb 21, 2020

We have a complex dependency tree we'd like to solve: sonata-project/dev-kit#216

Our next step is the admin bundle, so we can release all other bundles that rely on it

@core23
Copy link
Member

core23 commented May 28, 2020

Closing this in favor of #440

@core23 core23 closed this May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonataCoreBundle is deprecated
2 participants