Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use event_listener instead of event_subscriber #2411

Merged
merged 2 commits into from
Aug 1, 2023
Merged

use event_listener instead of event_subscriber #2411

merged 2 commits into from
Aug 1, 2023

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jul 31, 2023 •
edited by VincentLanglet
Loading

Subject

I am targeting this branch, because it should be BC.

Closes #2410.

Changelog

### Fixed
- Deprecation of Event Subscribers on Symfony 6.3. The MediaEventSubscriber now uses Event Listeners

@Hanmac
Copy link
Contributor Author

Hanmac commented Aug 1, 2023

@VincentLanglet the two failures seems to be false matches?

@VincentLanglet
Copy link
Member

@VincentLanglet the two failures seems to be false matches?

Yeah, for the PHPStan one we need a new twig release.

The psalm one is unrelated to your pr
I'll fix it with #2412

@VincentLanglet VincentLanglet merged commit ba76151 into sonata-project:4.x Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
2 participants
@Hanmac @VincentLanglet