Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SimpleResizer calculation in round() can return invalid value for image resizing. (4.x) #2405

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix: SimpleResizer calculation in round() can return invalid value for image resizing. (4.x) #2405

merged 1 commit into from
Jul 21, 2023

Conversation

silasjoisten
Copy link
Contributor

Subject

I am targeting this branch, because this is a bugfix.

the round method in the SimpleResizer can return 0 and thats invalid for image resizing.

Changelog

### Fixed
* `round()` can return 0 which is invalid for image resizing.

ref #2404

@VincentLanglet VincentLanglet mentioned this pull request Jul 21, 2023
Merged
@VincentLanglet
Copy link
Member

Thanks

@silasjoisten silasjoisten changed the title Fix: SimpleResizer calculation in round() can get return invalid value for image resizing. (4.x) Fix: SimpleResizer calculation in round() can return invalid value for image resizing. (4.x) Jul 21, 2023
@VincentLanglet VincentLanglet merged commit 3ce6ffb into sonata-project:4.x Jul 21, 2023
@silasjoisten silasjoisten deleted the fix/simple-resizer-v4 branch July 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silasjoisten @VincentLanglet