Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin dependency optional for blocks #2219

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

core23
Copy link
Member

@core23 core23 commented Nov 17, 2021

#2214 fixed most of the problems, but one block service was missing

Changelog

### Fixed
- Fix block service registration

@core23 core23 added the bug label Nov 17, 2021
@core23 core23 requested a review from a team November 17, 2021 20:17
src/Block/GalleryBlockService.php Outdated Show resolved Hide resolved
jordisala1991
jordisala1991 previously approved these changes Nov 17, 2021
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phpstan is failing.

@VincentLanglet VincentLanglet merged commit bc4c763 into sonata-project:4.x Nov 18, 2021
@core23 core23 deleted the block-service-fix branch November 18, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants