Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PHPStan configuration from master #2036

Merged
merged 3 commits into from
Aug 14, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Aug 13, 2021

Subject

Backport PHPStan configuration from master.

I am targeting this branch, because these changes respect BC.

Changelog

### Added
- PHPStan configuration and dependencies backported from `master` branch.

@phansys phansys requested a review from a team August 13, 2021 08:31
@phansys phansys marked this pull request as ready for review August 13, 2021 08:59
@VincentLanglet
Copy link
Member

Can you do the merge 3.x into master after @phansys ? I let you merge this PR

@phansys
Copy link
Member Author

phansys commented Aug 14, 2021

I let you merge this PR

What an honor! :trollface:
Sure, I'll create the merge.

After all, my main goal behind these changes is to fix some inconsistencies detected by PHPStan in the projects where I'm using this package, and I'd like to avoid polluting my code with annotations that belong here.

@VincentLanglet VincentLanglet merged commit cafbe30 into sonata-project:3.x Aug 14, 2021
@phansys phansys deleted the phpstan branch August 14, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants