-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow PHP 8.0 #1906
allow PHP 8.0 #1906
Conversation
Problem 1 fixed in the master branch in version 3.0 DataGritBunble - #1907 |
Problem 2 - waiting release - https://packagist.org/packages/liip/imagine-bundle#2.x-dev |
You need to rebase 3.x in order to fix some tests |
@VincentLanglet yes sure but tomorrow, today is a busy day sorry. |
Waiting support php 8.0 -> sonata-project/doctrine-orm-admin-bundle |
Blocked by auditEntityBundle ; but now it's a sonata project repository |
@VincentLanglet synchronized =) |
It needs a release for notification bundle |
And it will be blocked by this other package to: https://packagist.org/packages/kriswallsmith/buzz#v0.16.0 the latest 1.x release allows php 8 tho |
@Yozhef IMO you should move it to the master. I have prepared drop support for buzz and I will push it in Monday. CAn you do it? |
@wbloszyk moved to the master - I will be grateful for help, unfortunately, not much free time at the moment - but as soon as it appears ready to take on tasks with TODO |
Tests are passing now 🎉 |
You can move it to 3.x, because of this (and we need to discuss it if we want to give it support): It is installing kriswallsmith/buzz ^0.15, because that older version supports php > 5.3. On ^0.16 the requirement was changed to ^5.6 || ^7.0. I am not sure it will work with 0.15, but as far as composer requirements it works. (If we accept this, we should move it to 3.x because it will pass too). |
@jordisala1991 sorry for the long reaction changed to 3.x |
Thank you @Yozhef |
There is some issue with the changelog detection of this pr: https://d5zda2diva-x6miu6vkqhzpi.eu.s5y.io/next-release/media-bundle |
Changelog