Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow PHP 8.0 #1906

Merged
merged 3 commits into from
Mar 24, 2021
Merged

allow PHP 8.0 #1906

merged 3 commits into from
Mar 24, 2021

Conversation

Yozhef
Copy link
Contributor

@Yozhef Yozhef commented Jan 27, 2021

Changelog

### Added
- Added support for PHP 8.x

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 27, 2021

Problem 1 fixed in the master branch in version 3.0 DataGritBunble - #1907

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 27, 2021

Problem 2 - waiting release - https://packagist.org/packages/liip/imagine-bundle#2.x-dev

@VincentLanglet
Copy link
Member

You need to rebase 3.x in order to fix some tests

@Yozhef
Copy link
Contributor Author

Yozhef commented Feb 11, 2021

@VincentLanglet yes sure but tomorrow, today is a busy day sorry.

@Yozhef
Copy link
Contributor Author

Yozhef commented Feb 12, 2021

Waiting support php 8.0 -> sonata-project/doctrine-orm-admin-bundle

@VincentLanglet
Copy link
Member

Waiting support php 8.0 -> sonata-project/doctrine-orm-admin-bundle

Blocked by auditEntityBundle ; but now it's a sonata project repository
https://github.com/sonata-project/EntityAuditBundle

@Yozhef Yozhef closed this Feb 24, 2021
@Yozhef Yozhef reopened this Feb 24, 2021
@Yozhef
Copy link
Contributor Author

Yozhef commented Feb 24, 2021

@VincentLanglet synchronized =)

@jordisala1991
Copy link
Member

It needs a release for notification bundle

@jordisala1991
Copy link
Member

And it will be blocked by this other package to: https://packagist.org/packages/kriswallsmith/buzz#v0.16.0

the latest 1.x release allows php 8 tho

@wbloszyk
Copy link
Member

@Yozhef
To finish this PR you should add support for buzz 1.x or move it to the master branch where buzz will be removed.

IMO you should move it to the master. I have prepared drop support for buzz and I will push it in Monday.

CAn you do it?

@Yozhef Yozhef changed the base branch from 3.x to master March 15, 2021 09:42
@Yozhef
Copy link
Contributor Author

Yozhef commented Mar 15, 2021

@wbloszyk moved to the master - I will be grateful for help, unfortunately, not much free time at the moment - but as soon as it appears ready to take on tasks with TODO

@phansys
Copy link
Member

phansys commented Mar 24, 2021

Tests are passing now 🎉

@jordisala1991
Copy link
Member

You can move it to 3.x, because of this (and we need to discuss it if we want to give it support):

It is installing kriswallsmith/buzz ^0.15, because that older version supports php > 5.3. On ^0.16 the requirement was changed to ^5.6 || ^7.0.

I am not sure it will work with 0.15, but as far as composer requirements it works. (If we accept this, we should move it to 3.x because it will pass too).

@Yozhef Yozhef changed the base branch from master to 3.x March 24, 2021 16:53
@Yozhef
Copy link
Contributor Author

Yozhef commented Mar 24, 2021

@jordisala1991 sorry for the long reaction changed to 3.x

@VincentLanglet VincentLanglet requested a review from a team March 24, 2021 17:35
@wbloszyk wbloszyk merged commit ce90c31 into sonata-project:3.x Mar 24, 2021
@wbloszyk
Copy link
Member

Thank you @Yozhef

@VincentLanglet
Copy link
Member

There is some issue with the changelog detection of this pr: https://d5zda2diva-x6miu6vkqhzpi.eu.s5y.io/next-release/media-bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants