Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve orm XML mapping configuration #1832

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Oct 6, 2020

Subject

The *.orm.xml files contained some errors:

  • The xsi attributes were not setup properly, preventing validation in an XML editor.
  • The default values for three columns were configured using the default attribute. This attribute does not exist. A default value must be configured using the <options> subelement.

I have removed the default values altogether and not replaced them with the right configuration code, because this introduces schema changes. Apparently the bundle works fine without the defaults.

I am targeting this branch, because the changes are backwards compatible.

Changelog

### Fixed
- Fixed validity of *.orm.xml mapping files.

 * Fixed XMLSchema-instance definitions
 * Removed default values that were configured using a non-existent attribute
@phansys phansys requested a review from a team October 13, 2020 21:09
@greg0ire greg0ire merged commit 2110cea into sonata-project:3.x Oct 13, 2020
@greg0ire
Copy link
Contributor

Thanks @jorrit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants