Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some symfony/* dependencies to use version ^5.1 #1786

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Aug 20, 2020

Subject

Allow some symfony/* dependencies to use version ^5.1, since these major versions don't have breaking changes. See:

I am targeting this branch, because these changes respect BC.

Depends on sonata-project/SonataAdminBundle#6299.

Changelog

### Added
- Added support for symfony/filesystem:^5.1;
- Added support for symfony/options-resolver:^5.1.

@phansys phansys added the minor label Aug 20, 2020
@phansys phansys changed the title Allow some symfony/* dependencies to use version ^5.0 Allow some symfony/* dependencies to use version ^5.1 Aug 22, 2020
@phansys phansys requested a review from a team August 27, 2020 14:23
@phansys phansys marked this pull request as ready for review August 27, 2020 14:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #1786 into 3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1786   +/-   ##
=========================================
  Coverage     58.12%   58.12%           
  Complexity     1372     1372           
=========================================
  Files           127      127           
  Lines          4365     4365           
=========================================
  Hits           2537     2537           
  Misses         1828     1828           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d40d6...dfa1051. Read the comment docs.

@greg0ire greg0ire merged commit 2901e21 into sonata-project:3.x Aug 27, 2020
@greg0ire
Copy link
Contributor

Thanks @phansys !

@phansys phansys deleted the symfony_deps branch August 27, 2020 20:32
@tristanbes
Copy link
Contributor

Hello @greg0ire , is this possible to get a tag to benefit from this PR on a Symfony5.1 environement ?
Thanks 👍

@greg0ire
Copy link
Contributor

greg0ire commented Sep 2, 2020

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants