Address block bundle deprecations #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
approved these changes
Feb 13, 2020
|
Please add a changelog @franmomu |
greg0ire
approved these changes
Feb 13, 2020
|
@core23 why is this minor? |
Thought we use this for deprecation fixes. Feel free to change the label. |
|
We use that for new deprecations so that ppl getting a patch release do not get more deprecations, but for fixes, it's patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is BC.
Changelog
I did this in a separate PR since I'm not sure about how to deal with the
buildEditFormandpre*methods since I haven't found yet where they are used. I've seen theEditableBlockService, but not how to use it.