Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Symfony deprecations #1698

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Remove Symfony deprecations #1698

merged 3 commits into from
Feb 13, 2020

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Feb 13, 2020 •
edited
Loading

I am targeting this branch, because this is BC.

I labeled this as pedantic, should I add a changelog?

Changelog

### Changed
- Use Mime Component to guess extension

@franmomu franmomu changed the title Remove deprecations Remove Symfony deprecations Feb 13, 2020
@core23
Copy link
Member

core23 commented Feb 13, 2020

This is a code change. You switched the mime guess, so this is at least a minor change.

@core23 core23 added minor and removed pedantic labels Feb 13, 2020
@greg0ire greg0ire merged commit 8ba398a into sonata-project:3.x Feb 13, 2020
@greg0ire
Copy link
Contributor

Thanks @franmomu!

@franmomu franmomu deleted the remove_deprecations branch February 13, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franmomu @core23 @greg0ire