Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default resizer and default resizer adapter #1108

Merged
merged 1 commit into from
Aug 28, 2016

Conversation

core23
Copy link
Member

@core23 core23 commented Aug 27, 2016

I am targetting this branch, because this feature is BC.

Rebase of #721
Closes #700

Changelog

### Added
- Added config key to define default resizer
- Added config key to define default resizer adapter

Subject

Added two new config keys to define default resizer and resizer adapters to reduce duplicate configuration on each provider.

$bundles = array(
//
);
$this->container->setParameter('kernel.bundles', $bundles);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really useful?

@core23 core23 force-pushed the feature/default-resizer branch from c22af10 to 89fdc4a Compare August 27, 2016 20:52
@core23 core23 force-pushed the feature/default-resizer branch from 89fdc4a to de2bd56 Compare August 28, 2016 06:38
@OskarStark
Copy link
Member

LGTM 👍

@greg0ire greg0ire merged commit 2e47d75 into sonata-project:3.x Aug 28, 2016
@greg0ire
Copy link
Contributor

Thanks @core23 !

@core23 core23 deleted the feature/default-resizer branch August 28, 2016 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] add default resizer and default resizer adapter
4 participants