Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symfony 6 #646

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

VincentLanglet
Copy link
Member

Subject

Symfony 6 is supported by FriendsOfSymfony/FOSCKEditorBundle#239

Changelog

### Added
- Support for Symfony 6

@VincentLanglet
Copy link
Member Author

Now blocked by knplabs/knp-markdown-bundle

@VincentLanglet
Copy link
Member Author

Need to follow KnpLabs/KnpMarkdownBundle#111

@jordisala1991
Copy link
Member

It is really strange to have removed all the code related to ckeditor or markdown, but still have the dependencies, right?

@jordisala1991
Copy link
Member

Looking at: https://github.com/KnpLabs/KnpMarkdownBundle/releases

Even though we could restore support directly here for markdown, IMO this dependency is not well maintained.
I would vote to remove everything about markdown and have a documentation about how to add it in your own project.

@VincentLanglet
Copy link
Member Author

It is really strange to have removed all the code related to ckeditor or markdown, but still have the dependencies, right?

Indeed, I removed it.

I kept the ckeditor one since we plan on restoring the support.

@VincentLanglet VincentLanglet merged commit 735af7c into sonata-project:5.x Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants