Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated service and compiler #165

Merged
merged 1 commit into from
May 21, 2016
Merged

Remove deprecated service and compiler #165

merged 1 commit into from
May 21, 2016

Conversation

sagikazarmark
Copy link
Contributor

Changelog

### Removed
- Deprecated CKEditor Twig extension service and compiler

Subject

By leaving the now removed service and compiler in the package, but removing the underlying class 3.0.0 is broken and cannot be used. This PR removes the remaining references to that service, should be treated as PATCH.

@soullivaneuh
Copy link
Member

By leaving the now removed service and compiler in the package, but removing the underlying class 3.0.0 is broken and cannot be used.

Could you elaborate? What is the error?

@sagikazarmark
Copy link
Contributor Author

Fatal error: Class 'Sonata\FormatterBundle\Twig\Extension\CKEditorExtension' not found

I thought it was clear: the class has been removed, the service not.

@sagikazarmark
Copy link
Contributor Author

dabe00e

@soullivaneuh
Copy link
Member

Oh yes indeed! My mistake. And I forgot some things on composer too.

The tag is recent, unsuable and wrong with composer.

I think I'll delete v3.0.0 for now and re-push it.

@sagikazarmark
Copy link
Contributor Author

Thanks.

@soullivaneuh
Copy link
Member

I removed the tag for now. I'll write test for it, merge your PR, fix the composer issue and push a tag again this evening.

You should remove your sonata vendor folder from your project to not having conflict. 👍

@soullivaneuh soullivaneuh merged commit efe580a into sonata-project:3.x May 21, 2016
@sagikazarmark sagikazarmark deleted the remove_deprecations branch May 21, 2016 22:10
@soullivaneuh
Copy link
Member

soullivaneuh commented May 21, 2016

@sagikazarmark Can you confirm this solve your issue? All works as expected?

@sagikazarmark
Copy link
Contributor Author

Yes, it works perfectly.

@soullivaneuh
Copy link
Member

@sagikazarmark https://github.com/sonata-project/SonataFormatterBundle/releases/tag/3.0.0

Thanks a lot for the report and the help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants