-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated service and compiler #165
Remove deprecated service and compiler #165
Conversation
Could you elaborate? What is the error? |
I thought it was clear: the class has been removed, the service not. |
Oh yes indeed! My mistake. And I forgot some things on composer too. The tag is recent, unsuable and wrong with composer. I think I'll delete v3.0.0 for now and re-push it. |
Thanks. |
I removed the tag for now. I'll write test for it, merge your PR, fix the composer issue and push a tag again this evening. You should remove your sonata vendor folder from your project to not having conflict. 👍 |
@sagikazarmark Can you confirm this solve your issue? All works as expected? |
Yes, it works perfectly. |
@sagikazarmark https://github.com/sonata-project/SonataFormatterBundle/releases/tag/3.0.0 Thanks a lot for the report and the help! 👍 |
Changelog
Subject
By leaving the now removed service and compiler in the package, but removing the underlying class 3.0.0 is broken and cannot be used. This PR removes the remaining references to that service, should be treated as PATCH.