Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Fix missing missing parameter extension test #582

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

franmomu
Copy link
Member

I've tried to add the SonataAdminExtension to getContainerExtensions, but there a couple of problems here with the load method.

First it is dependent on the order the extensions were declared, it should iterate the extensions first and call prepend and then iterate them again and call load.

And then if you pass to the load method: $this->load(['document_tree' => []]);, both extension will try to load this configuration which is wrong.

So this is why I added sonata.admin.configuration.use_intl_templates parameter directly.

Ref: SymfonyTest/SymfonyDependencyInjectionTest#78

@greg0ire greg0ire merged commit 08efe44 into sonata-project:2.x Mar 21, 2020
@greg0ire
Copy link
Contributor

Thanks @franmomu !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants