This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Fix missing missing parameter extension test #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to add the
SonataAdminExtension
togetContainerExtensions
, but there a couple of problems here with theload
method.First it is dependent on the order the extensions were declared, it should iterate the extensions first and call
prepend
and then iterate them again and callload
.And then if you pass to the
load
method:$this->load(['document_tree' => []]);
, both extension will try to load this configuration which is wrong.So this is why I added
sonata.admin.configuration.use_intl_templates
parameter directly.Ref: SymfonyTest/SymfonyDependencyInjectionTest#78