Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters must respect createQuery() clauses #925

Closed
wants to merge 1 commit into from

Conversation

phansys
Copy link
Member

@phansys phansys commented Jun 17, 2019

Subject

Filters must respect createQuery() clauses.

I am targeting this branch, because these changes are BC.

Related to sonata-project/SonataAdminBundle#5569.

Changelog

### Fixed
- Clauses provided by `createQuery()` method being not respected with filters using "OR" condition.

To do

  • Update tests;
  • Validate that FilterInterface::apply() and FilterInterface::filter() can return values or find other approach;

@stale
Copy link

stale bot commented Jan 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2020
@SonataCI SonataCI removed the wontfix label Jan 30, 2020
@phansys phansys added the keep label Feb 1, 2020
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@phansys phansys added patch and removed bug labels Apr 11, 2020
@github-actions
Copy link

github-actions bot commented Oct 8, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants