Show embedded value in admin list #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
previously approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Is it possible to fix the psalm issue ? (Does it require a PR on SonataAdmin ?)
Are you up to date with 3.x ? The flint build should be fixed by this change: https://github.com/sonata-project/SonataDoctrineMongoDBAdminBundle/blob/3.x/.php_cs.dist#L59
I've silenced it in #544 and created sonata-project/SonataAdminBundle#6947 |
VincentLanglet
approved these changes
Mar 18, 2021
wbloszyk
approved these changes
Mar 18, 2021
jordisala1991
approved these changes
Mar 18, 2021
|
Thank you @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #545
Apparently it fails in
masterbranch, with this we'll make sure it works.