Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FieldDescriptionFactory #531

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Implement FieldDescriptionFactory #531

merged 1 commit into from
Mar 22, 2021

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Feb 14, 2021 •
edited
Loading

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Added `FieldDescriptionFactory` class to create FieldDescription instances.
### Deprecated
- Deprecated `ModelManager::getParentMetadataForProperty()` method.
- Deprecated `ModelManager::getNewFieldDescriptionInstance()` method.
- Deprecated `AbstractTypeGuesser` class.
- Deprecated `FilterTypeGuesser::guessType()` method.
- Deprecated `TypeGuesser::guessType()` method.
- Deprecated `ListBuilder::buildActionFieldDescription()` method.

@franmomu franmomu mentioned this pull request Feb 14, 2021
Merged
@franmomu franmomu force-pushed the field_description_factory branch from acf2327 to 3f2804b Compare February 16, 2021 01:09
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@dmaicher dmaicher mentioned this pull request Mar 13, 2021
Closed
@franmomu franmomu force-pushed the field_description_factory branch from 3f2804b to a55c38a Compare March 21, 2021 14:42
@franmomu franmomu force-pushed the field_description_factory branch 2 times, most recently from ab8f798 to ec97e1f Compare March 21, 2021 14:57
@franmomu franmomu marked this pull request as ready for review March 21, 2021 14:57
@franmomu franmomu requested a review from a team March 21, 2021 16:07
@franmomu franmomu added the minor label Mar 21, 2021
VincentLanglet
VincentLanglet previously approved these changes Mar 21, 2021
View reviewed changes
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@franmomu franmomu force-pushed the field_description_factory branch from ec97e1f to cead095 Compare March 21, 2021 21:48
VincentLanglet
VincentLanglet previously approved these changes Mar 21, 2021
View reviewed changes
phansys
phansys requested changes Mar 22, 2021
View reviewed changes
src/Guesser/AbstractTypeGuesser.php Outdated Show resolved Hide resolved
src/Model/ModelManager.php Outdated Show resolved Hide resolved
src/Guesser/AbstractTypeGuesser.php Outdated Show resolved Hide resolved
src/Model/ModelManager.php Outdated Show resolved Hide resolved
src/Model/ModelManager.php Outdated Show resolved Hide resolved
@franmomu franmomu force-pushed the field_description_factory branch from cead095 to 86bbf42 Compare March 22, 2021 07:05
@phansys phansys requested review from VincentLanglet and a team March 22, 2021 08:58
@jordisala1991 jordisala1991 merged commit cc89819 into sonata-project:3.x Mar 22, 2021
@jordisala1991
Copy link
Member

Thank you @franmomu

@franmomu franmomu deleted the field_description_factory branch March 22, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@VincentLanglet VincentLanglet Awaiting requested review from VincentLanglet

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franmomu @SonataCI @jordisala1991 @phansys @VincentLanglet