Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Add deprecations #742

Closed
wants to merge 1 commit into from
Closed

Conversation

wbloszyk
Copy link
Member

Subject

I am targeting this branch, because it is BC.

Part of #741

Changelog

## Deprecated
- all CoreBundle class and services

@wbloszyk wbloszyk mentioned this pull request May 21, 2020
8 tasks
@greg0ire
Copy link
Contributor

Maybe we should merge this after all code in our packages is migrated?

@wbloszyk
Copy link
Member Author

wbloszyk commented May 21, 2020

@greg0ire Please read #741 one more time. This way will be much better.
I have all this PRs prepared. Just check it and after all release. We can drop CoreBundle in Sonata 3. After this change we make sonata-project/dev-kit#697. Next will be sonata-project/SonataBlockBundle#700. Then we can focus how use 0.x extensions in Sonata 4.

@greg0ire
Copy link
Contributor

Maybe we should merge this after all code in our packages is migrated?

What I mean is maybe we should add deprecations only after sonata-project/dev-kit#697 is done. That way end users do not get deprecations they cannot fix.

@wbloszyk
Copy link
Member Author

Maybe we should merge this after all code in our packages is migrated?

What I mean is maybe we should add deprecations only after sonata-project/dev-kit#697 is done. That way end users do not get deprecations they cannot fix.

I understand what you mean. Anyway we cant done sonata-project/dev-kit#697 before #741. We need stable 0.x extensions and this is the easiest way to do it. We can add this deprecations after both issues but for now CoreBundle also have some deprecations which user couldn't fix. I think we should not avoid add new deprecations if in this way we can resolve this BIG CORE problem.

@greg0ire
Copy link
Contributor

It's it's much harder to add the deprecations later, don't do it. It's better DX but I'd rather have this done than discourage you 😅

@wbloszyk wbloszyk closed this May 23, 2020
@wbloszyk wbloszyk deleted the add_aliases branch May 25, 2020 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants