added test for InlineValidator #294
Conversation
codebach
force-pushed
the
test-for-sonata-core-bundle
branch
from
eb36a8c to
315cac9
Compare
|
|
||
| public function testGetErrorElement() | ||
| { | ||
| $inlineValidator = new InlineValidator($this->container, $this->constraintValidatorFactory); |
There was a problem hiding this comment.
Mother of god… do all classes depend on the container or what? T___T
There was a problem hiding this comment.
Mother of god… do all classes depend on the container or what? T___T
😆
There was a problem hiding this comment.
I think this should have been done with tagged services or something like that…
There was a problem hiding this comment.
but please lets do this in another PR
There was a problem hiding this comment.
but please lets do this in another PR
Sure goes without saying, this is more a call to action…
codebach
force-pushed
the
test-for-sonata-core-bundle
branch
2 times, most recently
from
5d43e76 to
e7e48ed
Compare
| use Sonata\CoreBundle\Validator\ErrorElement; | ||
|
|
||
| /** | ||
| * Class FooValidatorService. |
There was a problem hiding this comment.
This has been created automaticaly by the IDE. I will change it ok.
There was a problem hiding this comment.
I know I think we have the same. 👍
You can change it on settings.
There was a problem hiding this comment.
I have changed the comment.
codebach
force-pushed
the
test-for-sonata-core-bundle
branch
4 times, most recently
from
7e07d22 to
5bb5284
Compare
| { | ||
| $this->setExpectedException('Symfony\Component\Validator\Exception\ValidatorException', 'foo is equal to foo'); | ||
|
|
||
| $constraint = $this->getMock('Symfony\Component\Validator\Constraint', array('isClosure', 'getClosure')); |
There was a problem hiding this comment.
getMock is deprecated in favor of createMock
There was a problem hiding this comment.
Yes, but createMock is not available under PHPUnit 4. So let it as is for now.
There was a problem hiding this comment.
Oh, right… nevermind, then.
|
This PR is ready from my side. Anything I should change? |
| * | ||
| * @author Ahmet Akbana <[email protected]> | ||
| */ | ||
| class FooValidatorService |
codebach
force-pushed
the
test-for-sonata-core-bundle
branch
from
5bb5284 to
8c0c0c3
Compare
| use Symfony\Component\Validator\Exception\ValidatorException; | ||
|
|
||
| /** | ||
| * Test for InlineValidator. |
There was a problem hiding this comment.
For me this comment is useless.
By class InlineValidatorTest, we know this class is to test InlineValidator. 😉
codebach
force-pushed
the
test-for-sonata-core-bundle
branch
from
8c0c0c3 to
56c83eb
Compare
|
RTM. Thank you @ahmetakbn! 👍 |
|
Good job @ahmetakbn ! |
Subject
Test to increase code coverage of
SonataCoreBundle