Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.0 #725

Merged
merged 1 commit into from
Aug 11, 2020
Merged

4.3.0 #725

merged 1 commit into from
Aug 11, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Aug 11, 2020

No description provided.

@jordisala1991
Copy link
Member

I think we need to check 2 things:

  1. 3.x is merged on 4.x
  2. add the missing changelog from bugfixes / features from 3.x

This release is a bit harder than a normal one

@jordisala1991
Copy link
Member

I think the point 1. is done already

@jordisala1991
Copy link
Member

And for the second point I think we should only mention the support for doctrine/common 3

@phansys
Copy link
Member Author

phansys commented Aug 11, 2020

I think the point 1. is done already

Yes, currently there is nothing to compare between 4.x and 3.x.

@phansys
Copy link
Member Author

phansys commented Aug 11, 2020

And for the second point I think we should only mention the support for doctrine/common 3

I've updated the changelog through release command, with some minimal changes to target the 4.x branch. Is this mention omitted in the PR where the change was introduced?

@jordisala1991
Copy link
Member

I dont think so but it was for a Pr targeting 3.x branch and the command is not able to understand that a release for 4.x might contain changelog from Prs on 3.x branch

@phansys
Copy link
Member Author

phansys commented Aug 11, 2020

I just add the changelog comment from #710. Please, let me know if there is something else to improve.

@jordisala1991
Copy link
Member

I think it is great, thank you :)

@phansys phansys merged commit 4c2bc94 into sonata-project:4.x Aug 11, 2020
@phansys phansys deleted the release_4.3.0 branch August 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants