Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop old versions of Symfony #352

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Drop old versions of Symfony #352

merged 1 commit into from
Jan 9, 2017

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Jan 5, 2017

I am targetting this branch, because dropping versions of symfony is considered a BC-break.

Changelog

### Removed
- compatibility with symfony 2.3 through 2.7 was dropped

@greg0ire greg0ire added the major label Jan 5, 2017
@greg0ire greg0ire requested a review from core23 January 5, 2017 18:41
@greg0ire
Copy link
Contributor Author

greg0ire commented Jan 5, 2017 •
edited
Loading

Trying to understand why TF the tests failed 😓 with prefer lowest

@greg0ire
Copy link
Contributor Author

greg0ire commented Jan 5, 2017

Can't reproduce :/

@greg0ire
Copy link
Contributor Author

greg0ire commented Jan 5, 2017 •
edited
Loading

Restarting it in case it's transient (it might, be Response::getAge() seems to be time sensitive)

@greg0ire
Copy link
Contributor Author

greg0ire commented Jan 5, 2017

That was it. @sonata-project/contributors , please review.

@greg0ire greg0ire mentioned this pull request Jan 5, 2017
Closed
@greg0ire greg0ire force-pushed the drop_old_versions_of_sf branch from 7580cca to 3b94232 Compare January 8, 2017 21:56
@OskarStark OskarStark merged commit 45f4d58 into sonata-project:master Jan 9, 2017
@OskarStark
Copy link
Member

Thank you @greg0ire 👍

@greg0ire greg0ire deleted the drop_old_versions_of_sf branch January 9, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greg0ire @OskarStark @core23 @SonataCI