Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clashing global twig variable #8136

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Fix clashing global twig variable #8136

merged 1 commit into from
Dec 9, 2023

Conversation

core23
Copy link
Member

@core23 core23 commented Dec 7, 2023 •
edited
Loading

Subject

This PR fixes the problem, when the global variables have already been set:

Unable to add global "admin" as the runtime or the extensions have already been initialized.

I am targeting this branch, because this is a hotfix of #8125

Changelog

### Fixed
- Fix clashing global twig variables (admin, base_template) if already set

@core23 core23 added the bug label Dec 7, 2023
VincentLanglet
VincentLanglet reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rebase, the fix is fixed by #8133

src/Controller/CRUDController.php Outdated Show resolved Hide resolved
@jordisala1991 jordisala1991 added patch and removed bug labels Dec 9, 2023
@jordisala1991 jordisala1991 merged commit 3e4346a into sonata-project:4.x Dec 9, 2023
25 checks passed
@jordisala1991
Copy link
Member

Thanks @core23 , could you make the changelog a bit more specific about what are ths clashing variables?

@core23 core23 deleted the fix-global-twig branch December 9, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@core23 @jordisala1991 @VincentLanglet