-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoinject all admin variables #8116
Conversation
da978d5
to
4984fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated method should be added to the changelog
@@ -135,6 +135,9 @@ public function listAction(Request $request): Response | |||
$exportFormats = $exporter->getAvailableFormats($this->admin); | |||
} | |||
|
|||
/** | |||
* @psalm-suppress DeprecatedMethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A NEXT_MAJOR replace with render()
should be added (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NEXT_MAJOR
comment is pedantic because the annotation should provide enough information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we had to resolve all the 4.x NEXT_MAJOR some of them were not obvious, so there is never too much comment.
@psalm-suppress
just tell to ignore the deprecation but does not explain how to solve it.
At least
NEXT_MAJOR: Remplace this method by `$this->render`
above renderWithExtraParams
definition might be more useful than remove this method
.
This method should be depreacted too:
|
3916094
to
8f51141
Compare
8f51141
to
21b0b6c
Compare
Please review again |
Subject
I am targeting this branch, because this feature is BC.
Closes #7242
Changelog