Allow to disable icheck and to be able to use still choice field mask #8105
Conversation
goetas
changed the title
|
ah, wait, i forgot one thing |
goetas
force-pushed
the
icheck-disabled-choice-mask
branch
from
f2e88e1 to
5da2238
Compare
goetas
force-pushed
the
icheck-disabled-choice-mask
branch
from
5da2238 to
62077a2
Compare
goetas
force-pushed
the
icheck-disabled-choice-mask
branch
from
62077a2 to
89e16f1
Compare
|
updated |
…k with the expanded option
goetas
force-pushed
the
icheck-disabled-choice-mask
branch
from
89e16f1 to
6f97843
Compare
docs/cookbook/recipe_icheck.rst
Outdated
| @@ -43,3 +43,30 @@ set data attribute ``data-sonata-icheck = "false"`` to this form element:: | |||
| .. note:: | |||
|
|
|||
| You have to use false as string! ``"false"``! | |||
|
|
|||
| When using ``Sonata\AdminBundle\Form\Type\ChoiceFieldMaskType`` (or other types that inherit from it, such as ) | |||
There was a problem hiding this comment.
I think we don't need this extra-doc, no ?
There was a problem hiding this comment.
I have updated it now. I think that the doc is helpful, it took me some time to realize that the attribute needs to be added to the choice elements and not to the outer type
There was a problem hiding this comment.
You still need to pass icheck => false on choice elements even if we don't check for this in the html then ?
There was a problem hiding this comment.
yea, the thing is that the icheck js tries to apply itself on all the radio inputs, except the one that have data-sonata-icheck set to false, but then using the expanded choice, the attributes to the choice need to be passed independently
|
Thanks |
Subject
Allows to disable
icheckand to be able to use still choice field mask with the expanded optionI am targeting this branch, because is backward compatible.
Closes #8104
Changelog