Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of enums for nullable property #8091

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix display of enums for nullable property #8091

merged 2 commits into from
Aug 28, 2023

Conversation

bedfir
Copy link
Contributor

@bedfir bedfir commented Aug 17, 2023

Subject

Same issue than previously fixed in #8039

Changelog

### Fixed
- Fix display of enums for nullable property

@VincentLanglet
Copy link
Member

Regression was introduced here #8070 cc @phansys

Would be great if one could add a non-regression test

@VincentLanglet VincentLanglet requested a review from phansys August 26, 2023 13:05
@phansys
Copy link
Member

phansys commented Aug 26, 2023

Would be great if one could add a non-regression test

I'll try to take a look this week if it's not too late.
Thanks for pointing.

phansys
phansys requested changes Aug 27, 2023
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @bedfir!

src/Resources/views/CRUD/display_enum.html.twig Show resolved Hide resolved
@VincentLanglet VincentLanglet merged commit f37f99d into sonata-project:4.x Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bedfir @VincentLanglet @phansys