Attach the xhr violation error to the form field #7948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a screenshot of what you get ? |
VincentLanglet
previously approved these changes
Oct 15, 2022
|
Guys please merge PR and add a tag |
|
I'd like the review of @jordisala1991 first |
| const field = $(form).find(`[name='${violation.propertyPath}']`); | ||
| if (field.length) { | ||
| field.closest('.form-group').addClass('has-error xhr-violation-error'); | ||
| field.parent().append(`<div class="help-block sonata-ba-field-error-messages xhr-violation-error-block"> |
There was a problem hiding this comment.
This won't work if one field triggers 2 validation errors. IMO this code should be written in plain JS, and you can use some (or all) the logic written here: https://github.com/sonata-project/SonataPageBundle/blob/4.x/assets/js/composer.js#L255-L300
It should be quite similar.
|
Hi @jordisala1991, |
|
@jordisala1991 please check the pr |
jordisala1991
approved these changes
Oct 20, 2022
|
Thank you @ggabrovski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach the xhr violation error to the form field
In relation to @dmitryuk fix for #7945 #7946 it will be nice for the user to see the violation error message attached to the field. I suggest to add small logic to display this information on the right place.
Changelog