Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sonataIntl dependency #7932

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Sep 21, 2022

Subject

I am targeting this branch, because {reason}.

@VincentLanglet
Copy link
Member Author

@jordisala1991 Seems like we don't need SonataIntl for tests currently in SonataAdmin.

Maybe it's better to keep templates in SonataIntl and add test there then ?

If 10 repository provides customs template for Sonata, we should'nt had all of them in SonataAdmin, no ?

WDYT ?

@jordisala1991
Copy link
Member

Then sonata intl will require admin-bundle as dev-dep?

@jordisala1991
Copy link
Member

SEems like someone already reverted a removal of intlbundle: #5981, maybe we need to investigate further on why it was removed, and then reverted.

@VincentLanglet
Copy link
Member Author

SEems like someone already reverted a removal of intlbundle: #5981, maybe we need to investigate further on why it was removed, and then reverted.

This was done first #5835, the idea of copy pasting the template was the same (but also using others twig extensions)
but this wasn't working so it was reverting.

IMHO we should

  • remove sonataIntl from the dev-dependency
  • adding test on sonataIntl with sonataAdmin in dev-dependency

In next major we could remove to automatically override the template when sonataIntl is installed. And instead updating the doc for people to do it manually (or to move the code to sonataIntl).

This way

  • You can use sonataAdmin without SonataIntl and no occurence of SonataIntl will be in sonataAdmin
  • You can use sonataAdmin and SonataIntl without using the templates from SonataIntl
  • You can use sonataAdmin and SonataIntl and using the templates from SonataIntl

@jordisala1991
Copy link
Member

Agree with all.

@VincentLanglet VincentLanglet marked this pull request as ready for review September 21, 2022 12:56
@VincentLanglet VincentLanglet requested review from a team and jordisala1991 September 21, 2022 12:56
@VincentLanglet VincentLanglet merged commit 7ccb67e into sonata-project:4.x Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants