Add default actions translation for list view

[jordisala1991]

Subject

I am targeting this branch, because this is BC.

Changelog

### Fixed
- Fix missing default translation for actions label on list view.

[VincentLanglet]

I'm ok

[jordisala1991]

To me this will be useful mostly for our bundles, so we can only translate the default strategy, not all of them.

[VincentLanglet]

To me this will be useful mostly for our bundles, so we can only translate the default strategy, not all of them.

Yeah I agree.
Also, I looked at others strategy and some of them should be deprecated IMHO.

[VincentLanglet]

To me this will be useful mostly for our bundles, so we can only translate the default strategy, not all of them.

The default one is the native
https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php#L329

But we always use the underscore one
https://github.com/sonata-project/SonataPageBundle/blob/89013450f4e78cc79232d386ed27b9d0870c3030/src/Resources/config/admin.xml#L29

https://github.com/search?p=4&q=org%3Asonata-project+sonata.admin.label.strategy&type=Code

All the translator strategy:

• Noop https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/NoopLabelTranslatorStrategy.php
• Native https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/NativeLabelTranslatorStrategy.php
• Underscore https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/UnderscoreLabelTranslatorStrategy.php supported by your PR
• https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/FormLabelTranslatorStrategy.php

https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/BCLabelTranslatorStrategy.php should be deprecated IMHO. Should we deprecate more translatorStrategy ?

[jordisala1991]

To me this will be useful mostly for our bundles, so we can only translate the default strategy, not all of them.

The default one is the native https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php#L329

But we always use the underscore one https://github.com/sonata-project/SonataPageBundle/blob/89013450f4e78cc79232d386ed27b9d0870c3030/src/Resources/config/admin.xml#L29

https://github.com/search?p=4&q=org%3Asonata-project+sonata.admin.label.strategy&type=Code

All the translator strategy:

• Noop https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/NoopLabelTranslatorStrategy.php
• Native https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/NativeLabelTranslatorStrategy.php
• Underscore https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/UnderscoreLabelTranslatorStrategy.php supported by your PR
• https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/FormLabelTranslatorStrategy.php

https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Translator/BCLabelTranslatorStrategy.php should be deprecated IMHO. Should we deprecate more translatorStrategy ?

I would say probably only the BCLabel IMO.