Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure routeName and routePattern dynamically #7867

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jul 10, 2022

Subject

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

Changelog

### Added
- Added `AbstractAdmin::generateBaseRoutePattern()`
- Added `AbstractAdmin::generateBaseRouteName()`

### Deprecated
- Added `AbstractAdmin::$baseRoutePattern` property
- Added `AbstractAdmin::$baseRouteName` property

@jordisala1991
Copy link
Member

Why is not possible to use the configure method of the admin to change dinamically the values of those 2 properties?

src/Admin/AbstractAdmin.php Outdated Show resolved Hide resolved
src/Admin/AbstractAdmin.php Outdated Show resolved Hide resolved
@VincentLanglet
Copy link
Member Author

Why is not possible to use the configure method of the admin to change dinamically the values of those 2 properties?

Because the value is cached. The issue was reported on the pageBundle topics.

@eerison
Copy link
Contributor

eerison commented Jul 19, 2022

Hey @VincentLanglet what is missing in this ticket? can I help somehow?

@VincentLanglet
Copy link
Member Author

I need time to fix the test but feel free to do it

@eerison
Copy link
Contributor

eerison commented Jul 19, 2022

I need time to fix the test but feel free to do it

if I get some free time tomorrow I'll try :)

Edit 1: I won't be able to fix your pipelines :/, I started to check this ticket: sonata-project/SonataPageBundle#1442

@VincentLanglet VincentLanglet marked this pull request as ready for review July 20, 2022 11:09
@VincentLanglet VincentLanglet requested review from jordisala1991 and a team July 20, 2022 11:10
@jordisala1991 jordisala1991 merged commit e959a59 into sonata-project:4.x Jul 20, 2022
@jordisala1991
Copy link
Member

Thanks @VincentLanglet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants