admin value resolver accept generat AdminInterface type #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VincentLanglet The PR is ready for #7846 |
|
Do we have any docs for this feature? |
Yes there is in the Decouple from CRUDController but not specific to inject AdminInterface. I did add an example in the batch controller documentation. I will add one to the documentation above. |
|
That would be great |
mpoiriert
force-pushed
the
issue-7846-admin-value-resolver
branch
from
83acf10 to
81aedad
Compare
|
Done |
VincentLanglet
approved these changes
Jun 15, 2022
jordisala1991
approved these changes
Jun 15, 2022
|
Thanks @mpoiriert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because the bug is present in this branch.
Closes #7846.
Changelog
### Fixed AdminValueResolver does support generic AdminInterface type.