Fix assertions in tests

[VincentLanglet]

No description provided.

[jordisala1991]

Why you removed this?

[VincentLanglet]

Because currently it's not really immutable

52     @readonly property Sonata\AdminBundle\Filter\Model\FilterData::$type   
         is assigned outside of the constructor.                                
  56     @readonly property Sonata\AdminBundle\Filter\Model\FilterData::$value  
         is assigned outside of the constructor.                                
  57     @readonly property                                                     
         Sonata\AdminBundle\Filter\Model\FilterData::$hasValue is assigned      
         outside of the constructor.          

[VincentLanglet]

https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-immutable
and https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-readonly-and-readonly

[franmomu]

I'm not sure if this is a bug in psalm, those properties are accessed in a named constructor, that doesn't make the class mutable

[franmomu]

I think we should ignore those false positives instead of removing the immutability

[VincentLanglet]

I think we should ignore those false positives instead of removing the immutability

I don't consider this like a false positive.

The @readonly doc say

Used to annotate a property that can only be written to in its defining class's constructor.

We're not writting them in the class-constructor but in a custom method fromArray.
Psalm is not reporting an error for https://psalm.dev/r/aa6df26b17, but I consider this to be immutable since I changed the value multiples times.

I you want this class to be really immutable you should use the constructor ; it would be a BC PR since the constructor is private

[franmomu]

We're not writting them in the class-constructor but in a custom method fromArray. Psalm is not reporting an error for https://psalm.dev/r/aa6df26b17, but I consider this to be immutable since I changed the value multiples times.

That's like if in the constructor you change the value multiple times, at the end is about getting a new object.

I you want this class to be really immutable you should use the constructor ; it would be a BC PR since the constructor is private

Being the constructor private is what prevents us from BC break, since we can change it and call it from fromArray with the three values.