Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend deps #7803

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Apr 28, 2022

Subject

I am targeting this branch, because this is BC.

Closes #7788.

Changelog

### Fixed
- Fix vulnerabilities on several frontend dependencies by upgrading them: `async`, `minimist`, `ansi-regex` and `moment`, 

@jordisala1991 jordisala1991 merged commit bf24ba5 into sonata-project:4.x Apr 28, 2022
@jordisala1991 jordisala1991 deleted the hotfix/upgrade-frontend-deps branch April 28, 2022 07:01
@VincentLanglet
Copy link
Member

Shouldn't we add a changelog ?

@jordisala1991
Copy link
Member Author

Wasn't sure if it is worth it, some of the updated deps contained fixes for security vulnerabilities, so maybe yes?

@jordisala1991
Copy link
Member Author

How do you see it now?

@VincentLanglet
Copy link
Member

Wasn't sure if it is worth it, some of the updated deps contained fixes for security vulnerabilities, so maybe yes?

Pedantic doesnt trigger a release. We might doesnt want to wait in order to release this so patch is good.

Also, the dependencies might have introduced bugs, so it's always useful to say "be aware we updated them"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants