Fix compatibility with PHP 8.1 in base_show_field.html.twig #7622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Twig\Error\RuntimeError: nl2br(): Passing null to parameter sonata-project#1 ($string) of type string is deprecated
|
@jordisala1991 Seems like it's not caught by your PR testing 8.1 |
|
It is a deprecation, not an actual error. There are 2 deprecations on 8.1 detected by tests but not this one. Maybe we are not testing this one. |
franmomu
approved these changes
Nov 26, 2021
VincentLanglet
approved these changes
Nov 26, 2021
core23
approved these changes
Nov 26, 2021
|
thanks @javer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Fixes Twig\Error\RuntimeError:
nl2br(): Passing null to parameter #1 ($string) of type string is deprecatedduring rendering nullable text field.I am targeting 4.x branch, because the change is backwards compatible and just fixes a deprecation notice.
Changelog