Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add lost feature from merge 3.x into 4.x #7617

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Re-add lost feature from merge 3.x into 4.x #7617

merged 2 commits into from
Nov 25, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Nov 25, 2021 •
edited
Loading

Subject

This was added in https://github.com/sonata-project/SonataAdminBundle/pull/7564/files
and lost in the merge https://github.com/sonata-project/SonataAdminBundle/pull/7570/files

Changelog

### Added
- The ability to not add a `select` column when accessing to the List with AJAX.

### Deprecated
- template `src/Resources/views/CRUD/base_list_flat_field.html.twig`
- template `src/Resources/views/CRUD/base_list_flat_inner_row.html.twig`

@franmomu
Copy link
Member

Can you please also resolve the NEXT_MAJOR comments added there? like deprecating the templates.

@VincentLanglet
Copy link
Member Author

Can you please also resolve the NEXT_MAJOR comments added there? like deprecating the templates.

Done

@VincentLanglet VincentLanglet requested a review from a team November 25, 2021 15:48
@VincentLanglet VincentLanglet merged commit a643065 into sonata-project:4.x Nov 25, 2021
@VincentLanglet VincentLanglet deleted the fixSelect branch November 25, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@franmomu franmomu franmomu approved these changes

Assignees
No one assigned
Labels
feature minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @franmomu @jordisala1991