Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuditReaderInterface generic #7561

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Make AuditReaderInterface generic #7561

merged 1 commit into from
Oct 29, 2021

Conversation

VincentLanglet
Copy link
Member

Subject

I am targeting this branch, because BC.

Allow to fix the build in DoctrineORM with this sonata-project/SonataDoctrineORMAdminBundle@d7b5330

Changelog

### Added
- Make AuditReaderInterface generics.

@VincentLanglet VincentLanglet requested review from phansys, a team and jordisala1991 October 28, 2021 18:16
@VincentLanglet VincentLanglet requested a review from a team October 28, 2021 19:29
@jordisala1991 jordisala1991 merged commit 4fc33a0 into sonata-project:4.x Oct 29, 2021
@jordisala1991
Copy link
Member

Thanks @VincentLanglet

@VincentLanglet VincentLanglet deleted the auditReader branch October 29, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@dmaicher dmaicher dmaicher approved these changes

@phansys phansys Awaiting requested review from phansys

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @jordisala1991 @dmaicher