Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no subject error on nested collection #7556

Merged

Conversation

Pasttaga
Copy link
Contributor

@Pasttaga Pasttaga commented Oct 25, 2021

Subject

Nested collection in form not work with more than 2 levels.
This PR fix error 'Admin has no subject'.

I am targeting this branch, because it's probably a bug.

Closes #7532.

Changelog

### Fixed
- Set subject of $associationAdmin when collection is append to childs collections.

@jordisala1991
Copy link
Member

@Pasttaga or @VincentLanglet do you think this can be tested?

@Pasttaga
Copy link
Contributor Author

@Pasttaga or @VincentLanglet do you think this can be tested?

I think one more level can be tested in test Sonata\AdminBundle\Tests\Admin\AdminHelperTest::testAppendFormFieldElementWithCollection() i try it without success for the moment.

@VincentLanglet VincentLanglet requested a review from a team October 25, 2021 09:47
@VincentLanglet
Copy link
Member

@Pasttaga or @VincentLanglet do you think this can be tested?

It could. But I'm not sure it will be easy.

@jordisala1991 jordisala1991 merged commit 4723a2e into sonata-project:4.x Oct 25, 2021
@jordisala1991
Copy link
Member

Thanks @Pasttaga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No subject on add collection element
3 participants