Use ArrayAccess interface instead of Doctrine Collection #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sonata-project#7538. Instead of using the Collection interface an easy switch to ArrayAccess interface can be used.
TheFox
changed the title
Check if it's ArrayAccess or array. Fixes sonata-project#7538.
| @@ -240,10 +240,10 @@ public function appendFormFieldElement(AdminInterface $admin, $subject, $element | |||
|
|
|||
| $collection = $this->propertyAccessor->getValue($subject, $path); | |||
|
|
|||
| if (!($collection instanceof Collection)) { | |||
| if (!($collection instanceof \ArrayAccess) && !is_array($collection)) { | |||
There was a problem hiding this comment.
I think the () around instanceof are unnecesary.
|
I just realized that this would not fix the other issue in #7538. It's also about Nested Collections. When I add a nested collection in level 2 I get this error: |
|
Hi, can you rebase ? |
|
I found one case where we use this strategy too, so this Pr makes sense to me. (the case is located at the appenParentObject of the on AbstractAdmin) |
|
Do you have the time to finish the PR @TheFox ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because it's a fix for version 3.
Closes #7538.
Changelog