Set order from sort_parameters as fallback #7529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This was triggered investigating the warnings triggered by PHP 8.1: https://github.com/sonata-project/SonataAdminBundle/pull/7528/checks?check_run_id=3837943478#step:10:53
The problem is that when doing
{{ sort_by|lower }}
,sort_by
isnull
in our tests.This PR will partially fix it (I'll make another one in
4.x
removing our implementation in tests ofDatagridInterface
and using the one from the bundle).What it does it to set the order from
sort_parameters
if it is not defined in the field description.I am targeting this branch, because this is a bugfix.
Changelog