Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce HISTORY role #7464

Merged
merged 2 commits into from
Sep 5, 2021
Merged

Introduce HISTORY role #7464

merged 2 commits into from
Sep 5, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Aug 31, 2021 •
edited
Loading

Subject

I am targeting this branch, because there is no real BC way to do it.
It will be a BC-break only for revisions users (with EntityAuditBundle).

Closes #7444.

Changelog

### Added
- New role `ROLE_MYADMIN_HISTORY` to access to the history actions

### Changed
- `AbstractAdmin::getAccessMapping` visibility

### Removed
- Access to the history actions with the role `ROLE_MYADMIN_EDIT` 
- `AdminInterface::getAccessMapping` method

@VincentLanglet VincentLanglet requested review from a team and jordisala1991 August 31, 2021 20:06
@VincentLanglet VincentLanglet added this to the 4.0 milestone Aug 31, 2021
core23
core23 previously requested changes Sep 1, 2021
View reviewed changes
src/Admin/AbstractAdmin.php
@@ -1731,11 +1724,6 @@ final public function getListMode(): string
return $this->getRequest()->getSession()->get(sprintf('%s.list_mode', $this->getCode()), 'list');
}

final public function getAccessMapping(): array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should mention this inside the CHANGELOG.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@VincentLanglet VincentLanglet requested a review from a team September 5, 2021 17:40
@jordisala1991 jordisala1991 merged commit c6b92d3 into sonata-project:4.x Sep 5, 2021
@jordisala1991
Copy link
Member

Thanks @VincentLanglet

@VincentLanglet VincentLanglet deleted the history branch September 5, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@dmaicher dmaicher dmaicher approved these changes

@franmomu franmomu Awaiting requested review from franmomu

@core23 core23 Awaiting requested review from core23

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

history, historyViewRevision and historyCompareRevisions should have his own permission map HISTORY
4 participants
@VincentLanglet @jordisala1991 @dmaicher @core23