Avoid missing translation on batch confirmation #7455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because bug fix.
When we render FilterDataType in the datagrid we only use form_widget, so the label is not needed.
When we render it in the batch confirmation page we render everything in display none, so the label are translated.
This PR solve this.
This solve half of the issue #4069, I don't know if we want to do more for this issue.
In order to use
HiddenType
in the batch confirmation we need to changeto
This means we need a different method to get the Form, and to get an HiddenForm.
Do we want to add a method to the datagridInterface just for this ?
Changelog