Make some method of the CRUDController final #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
finalCrud
branch
from
a894ad5 to
3d0e32c
Compare
franmomu
reviewed
Jun 13, 2021
| */ | ||
| protected function renderWithExtraParams(string $view, array $parameters = [], ?Response $response = null): Response | ||
| final protected function renderWithExtraParams(string $view, array $parameters = [], ?Response $response = null): Response |
There was a problem hiding this comment.
shouldn't we add @final in 3.x to these methods to warn users?
There was a problem hiding this comment.
I will do. I prefer to first decide what should be final.
dmaicher
approved these changes
Jun 15, 2021
jordisala1991
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC-break.
I let as non final
addRenderExtraParamsintroduced here: Allow reuse render extra parameters #5965 ; but I'm considering removing this method the day we've solved Extract the way we choosebase_templatefor actions #7242getLoggerbut I'm not sure about this one.getBaseTemplatehandleModelManagerExceptionpreCreateand similar methods.handleXmlHttpRequestErrorResponseandhandleXmlHttpRequestSuccessResponseintroduced here: Make handle xml http request response protected #6214Changelog