Also check for id in assertObjectExists #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Controller/CRUDController.php
Outdated
| )); | ||
| } | ||
| $adminObject = $admin->getObject($objectId); | ||
| if (null === $adminObject) { |
There was a problem hiding this comment.
why do you need an extra assert if you are checking here? Maybe make this method final fixes it?
There was a problem hiding this comment.
The method is already final.
But phpstan/psalm doesn't know what's happening in the method.
There was a problem hiding this comment.
Plus (next commit), the check cannot be done for list and create actions.
phansys
approved these changes
Jun 6, 2021
| @@ -1658,23 +1671,27 @@ protected function handleXmlHttpRequestSuccessResponse(Request $request, object | |||
| ], Response::HTTP_OK); | |||
| } | |||
|
|
|||
| final protected function assertObjectExists(Request $request): void | |||
| final protected function assertObjectExists(Request $request, bool $strict = false): void | |||
There was a problem hiding this comment.
In which cases you want to call it with false?
There was a problem hiding this comment.
For listAction and createAction.
There is no id in the request for the current admin.
But if it's a childAdmin, there will be id for the parent admin, grand-parent admin, and so on.
jordisala1991
approved these changes
Jun 8, 2021
|
Thanks @VincentLanglet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog